devs/foxbox
1
0
Fork 0
forked from len0rd/rockbox
Code Pull requests Activity

Fix #13369: shuffle setting not working from shortcut.

Browse source 
Setting in shortcut was not being handled as it had no callback.
In the settings menu it looks like the event is handled separately.
Added a shuffle callback to the setting so it is called when changed
from the shortcut.

Edit: move callback to within settings_list so playlist interface is
unchanged.

Change-Id: I3691acac1c73a80bf67c0b8b334009ef1655fdb0
This commit is contained in:
JJ Style 2023-08-24 23:25:27 +01:00 • committed by William Wilgus
parent 03d326fc90
commit 8a22660770
1 changed files with 15 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

16
apps/settings_list.c
View file

@ -63,6 +63,7 @@
#include "onplay.h"
#include "misc.h" /* current activity */
#endif
#include "playlist.h"
#include "voice_thread.h"
@ -618,6 +619,19 @@ static void eq_set_default(void* setting, void* defaultval)
memcpy(setting, defaultval, sizeof(struct eq_band_setting));
}
/* perform shuffle/unshuffle of the current playlist based on the boolean provided */
static void shuffle_playlist_callback(bool shuffle)
{
if (shuffle)
{
playlist_randomise(NULL, current_tick, true);
}
else
{
playlist_sort(NULL, true);
}
}
#ifdef HAVE_QUICKSCREEN
static void qs_load_from_cfg(void *var, char *value)
{
@ -898,7 +912,7 @@ const struct settings_list settings[] = {
#endif
/* playback */
OFFON_SETTING(0, playlist_shuffle, LANG_SHUFFLE, false, "shuffle", NULL),
OFFON_SETTING(0, playlist_shuffle, LANG_SHUFFLE, false, "shuffle", shuffle_playlist_callback),
SYSTEM_SETTING(NVRAM(4), resume_index, -1),
SYSTEM_SETTING(NVRAM(4), resume_crc32, -1),
SYSTEM_SETTING(NVRAM(4), resume_elapsed, -1),