Get rid of stupid _backlight_* function names

_remote_backlight_* and _buttonlight_* are cleaned as well

Change-Id: I73653752831bbe170c26ba95d3bc04c2e3a5cf30

firmware/target/arm/tms320dm320/creative-zvm/backlight-target.h

@@ -22,10 +22,10 @@
 #ifndef BACKLIGHT_TARGET_H
 #define BACKLIGHT_TARGET_H
 
-bool _backlight_init(void);
-void _backlight_on(void);
-void _backlight_off(void);
-void _backlight_set_brightness(int brightness);
+bool backlight_hw_init(void);
+void backlight_hw_on(void);
+void backlight_hw_off(void);
+void backlight_hw_brightness(int brightness);
 
 /* true: backlight fades off - false: backlight fades on */
 void __backlight_dim(bool dim);

firmware/target/arm/tms320dm320/mrobe-500/backlight-mr500.c

@@ -55,7 +55,7 @@ static void _backlight_write_brightness(int brightness)
     spi_block_transfer(SPI_target_BACKLIGHT, bl_command, 4, 0, 0);
 }
 
-void _backlight_on(void)
+void backlight_hw_on(void)
 {
     lcd_awake(); /* power on lcd + visible display */
 
@@ -64,25 +64,25 @@ void _backlight_on(void)
 #endif
 }
 
-void _backlight_off(void)
+void backlight_hw_off(void)
 {
     _backlight_write_brightness(0);
 }
 
 /* Assumes that the backlight has been initialized */
-void _backlight_set_brightness(int brightness)
+void backlight_hw_brightness(int brightness)
 {
     _backlight_write_brightness(brightness);
 }
 
 void __backlight_dim(bool dim_now)
 {
-    _backlight_set_brightness(dim_now ?
+    backlight_hw_brightness(dim_now ?
         DEFAULT_BRIGHTNESS_SETTING :
         DEFAULT_DIMNESS_SETTING);
 }
 
-bool _backlight_init(void)
+bool backlight_hw_init(void)
 {
     short read_value;
 
@@ -102,7 +102,7 @@ bool _backlight_init(void)
 
     spi_block_transfer(SPI_target_BACKLIGHT, commands[2], 2, 0, 0);
 
-    _backlight_set_brightness(backlight_brightness);
+    backlight_hw_brightness(backlight_brightness);
     return true;
 }
 

firmware/target/arm/tms320dm320/mrobe-500/backlight-target.h

@@ -22,10 +22,10 @@
 #ifndef BACKLIGHT_TARGET_H
 #define BACKLIGHT_TARGET_H
 
-bool _backlight_init(void);
-void _backlight_on(void);
-void _backlight_off(void);
-void _backlight_set_brightness(int brightness);
+bool backlight_hw_init(void);
+void backlight_hw_on(void);
+void backlight_hw_off(void);
+void backlight_hw_brightness(int brightness);
 
 /* true: backlight fades off - false: backlight fades on */
 void __backlight_dim(bool dim);

firmware/target/arm/tms320dm320/mrobe-500/lcd-remote-mr500.c

@@ -292,13 +292,13 @@ void lcd_remote_update_rect(int x, int y, int width, int height)
     remote_state_control=REMOTE_CONTROL_DRAW;
 }
 
-void _remote_backlight_on(void)
+void remote_backlight_hw_on(void)
 {
     remote_power|=0x40;
     remote_state_control_next=REMOTE_CONTROL_POWER;
 }
 
-void _remote_backlight_off(void)
+void remote_backlight_hw_off(void)
 {
     remote_power&=~(0x40);
     remote_state_control_next=REMOTE_CONTROL_POWER;

firmware/target/arm/tms320dm320/mrobe-500/power-mr500.c

@@ -75,7 +75,7 @@ bool ide_powered(void)
 void power_off(void)
 {
     /* turn off backlight and wait for 1 second */
-    _backlight_off();
+    backlight_hw_off();
 #if defined(HAVE_REMOTE_LCD)
     lcd_remote_sleep();
 #endif

firmware/target/arm/tms320dm320/sansa-connect/avr-sansaconnect.c

@@ -92,15 +92,15 @@ static void handle_wheel(unsigned char wheel)
     static unsigned char velocity = 0;
     static unsigned long wheel_delta = 1ul << 24;
     static unsigned char wheel_prev = 0;
-    static long next_backlight_on = 0;
+    static long nextbacklight_hw_on = 0;
     static int prev_key = -1;
     static int prev_key_post = 0;
 
-    if (TIME_AFTER(current_tick, next_backlight_on))
+    if (TIME_AFTER(current_tick, nextbacklight_hw_on))
     {
         backlight_on();
         reset_poweroff_timer();
-        next_backlight_on = current_tick + HZ/4;
+        nextbacklight_hw_on = current_tick + HZ/4;
     }
 
     if (wheel_prev < wheel)

firmware/target/arm/tms320dm320/sansa-connect/backlight-sansaconnect.c

@@ -50,7 +50,7 @@ static void _backlight_write_brightness(int brightness)
     IO_CLK_PWM1H = brightness*70;
 }
 
-void _backlight_on(void)
+void backlight_hw_on(void)
 {
 #ifdef HAVE_LCD_SLEEP
     if (!lcd_active())
@@ -67,7 +67,7 @@ void _backlight_on(void)
 #endif
 }
 
-void _backlight_off(void)
+void backlight_hw_off(void)
 {
     _backlight_write_brightness(0);
 
@@ -77,23 +77,23 @@ void _backlight_off(void)
 }
 
 /* Assumes that the backlight has been initialized */
-void _backlight_set_brightness(int brightness)
+void backlight_hw_brightness(int brightness)
 {
     _backlight_write_brightness(brightness);
 }
 
 void __backlight_dim(bool dim_now)
 {
-    _backlight_set_brightness(dim_now ?
+    backlight_hw_brightness(dim_now ?
         DEFAULT_BRIGHTNESS_SETTING :
         DEFAULT_DIMNESS_SETTING);
 }
 
-bool _backlight_init(void)
+bool backlight_hw_init(void)
 {
     IO_CLK_PWM1C = 0x58D; /* as found in OF */
 
-    _backlight_set_brightness(backlight_brightness);
+    backlight_hw_brightness(backlight_brightness);
     return true;
 }
 

firmware/target/arm/tms320dm320/sansa-connect/backlight-target.h

@@ -22,10 +22,10 @@
 #ifndef BACKLIGHT_TARGET_H
 #define BACKLIGHT_TARGET_H
 
-bool _backlight_init(void);
-void _backlight_on(void);
-void _backlight_off(void);
-void _backlight_set_brightness(int brightness);
+bool backlight_hw_init(void);
+void backlight_hw_on(void);
+void backlight_hw_off(void);
+void backlight_hw_brightness(int brightness);
 
 /* true: backlight fades off - false: backlight fades on */
 void __backlight_dim(bool dim);