devs/foxbox
1
0
Fork 0
forked from len0rd/rockbox
Code Pull requests Activity

Don't use NUM_VOLUMES as array size in sd card drivers. NUM_DRIVES is also wrong (the total number of drives in the system is not really related to the number of sd devices), but at least it's less wrong than NUM_VOLUMES and it matches the (wrong) assumptions the rest of the drivers make

Browse source 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@30569 a1c6a512-1295-4272-9138-f99709370657
This commit is contained in:
Frank Gevaerts 2011-09-18 12:51:54 +00:00
parent 28d5f2aa57
commit 85ad768b6e
2 changed files with 2 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

2
firmware/target/arm/as3525/sd-as3525.c
View file

@ -137,7 +137,7 @@ static bool hs_card = false;
#endif #endif
static struct semaphore transfer_completion_signal; static struct semaphore transfer_completion_signal;
static volatile unsigned int transfer_error[NUM_VOLUMES]; static volatile unsigned int transfer_error[NUM_DRIVES];
#define PL180_MAX_TRANSFER_ERRORS 10 #define PL180_MAX_TRANSFER_ERRORS 10
#define UNALIGNED_NUM_SECTORS 10 #define UNALIGNED_NUM_SECTORS 10

2
firmware/target/arm/s3c2440/sd-s3c2440.c
View file

@ -120,7 +120,7 @@ static const char sd_thread_name[] = "sd";
static struct mutex sd_mtx SHAREDBSS_ATTR; static struct mutex sd_mtx SHAREDBSS_ATTR;
static struct event_queue sd_queue; static struct event_queue sd_queue;
static struct semaphore transfer_completion_signal; static struct semaphore transfer_completion_signal;
static volatile unsigned int transfer_error[NUM_VOLUMES]; static volatile unsigned int transfer_error[NUM_DRIVES];
/* align on cache line size */ /* align on cache line size */
static unsigned char aligned_buffer[UNALIGNED_NUM_SECTORS * SD_BLOCK_SIZE] static unsigned char aligned_buffer[UNALIGNED_NUM_SECTORS * SD_BLOCK_SIZE]
__attribute__((aligned(32))); __attribute__((aligned(32)));