devs/foxbox
1
0
Fork 0
forked from len0rd/rockbox
Code Pull requests Activity

rbcodec dsp: Remove INIT_ATTR from the DSP library

Browse source 
All of these are technically unsafe cross-section references but
most aren't reported by the linker, probably due to inlining. In
practice there was no problem because the affected code was only
run at init time anyway.

For now, remove INIT_ATTR until the init code can be refactored
to avoid the problematic references. This should also save code
size by moving more code to the init section.

dsp_init() gets to keep its attribute because it's already OK.

Change-Id: Idc9ac0e02cb07f31d186686e0382275c02a85dbb
This commit is contained in:
Aidan MacDonald 2022-12-03 15:04:06 +00:00
parent b650e774a1
commit 8165a6c245
8 changed files with 15 additions and 20 deletions
Download patch file Download diff file Expand all files Collapse all files

3
lib/rbcodec/dsp/dsp_misc.c
View file

@ -149,8 +149,7 @@ unsigned int dsp_get_output_frequency(struct dsp_config *dsp)
return dsp_configure(dsp, DSP_GET_OUT_FREQUENCY, 0);
}
static void INIT_ATTR misc_dsp_init(struct dsp_config *dsp,
enum dsp_ids dsp_id)
static void misc_dsp_init(struct dsp_config *dsp, enum dsp_ids dsp_id)
{
/* Enable us for the audio DSP at startup */
if (dsp_id == CODEC_IDX_AUDIO)