devs/foxbox
1
0
Fork 0
forked from len0rd/rockbox
Code Pull requests Activity

puzzles: fix crash when loading a corrupt save

Browse source 
I misread the documentation here, thinking that the pointer would be set to
*point to* a null byte, not to a null pointer itself. [1]

[1]: https://www.chiark.greenend.org.uk/~sgtatham/puzzles/devel/midend.html#identify-game

Change-Id: I9b76bba9b1611dfd8e05d076a69f7554b5b74c53
This commit is contained in:
Franklin Wei 2020-06-27 20:24:31 -04:00
parent c02a9c5ab3
commit 7da8137bdb
1 changed files with 1 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

3
apps/plugins/puzzles/rockbox.c
View file

@ -3201,9 +3201,8 @@ static bool load_game(void)
char *game; char *game;
const char *ret = identify_game(&game, read_wrapper, (void*)fd); const char *ret = identify_game(&game, read_wrapper, (void*)fd);
if(!*game && ret) if(!game && ret)
{ {
sfree(game);
rb->splash(HZ, ret); rb->splash(HZ, ret);
rb->close(fd); rb->close(fd);
return false; return false;