devs/foxbox
1
0
Fork 0
forked from len0rd/rockbox
Code Pull requests Activity

Reduce the amount of stack space needed by fat_rename and mkdir_uncached.

Browse source 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@28576 a1c6a512-1295-4272-9138-f99709370657
This commit is contained in:
Michael Sparmann 2010-11-13 15:41:18 +00:00
parent 47bbd6a466
commit 79d26ed7f9
2 changed files with 29 additions and 16 deletions
Download patch file Download diff file Expand all files Collapse all files

25
firmware/common/dir_uncached.c
View file

@ -204,13 +204,28 @@ int mkdir_uncached(const char *name)
char *basename;
char *parent;
struct dirent_uncached *entry;
struct fat_dir newdir;
int dd;
DIR_UNCACHED* pdir = opendirs;
struct fat_dir *newdir;
int rc;
if ( name[0] != '/' ) {
DEBUGF("mkdir: Only absolute paths supported right now\n");
return -1;
}
/* find a free dir descriptor */
for ( dd=0; dd<MAX_OPEN_DIRS; dd++, pdir++)
if ( !pdir->busy )
break;
if ( dd == MAX_OPEN_DIRS ) {
DEBUGF("Too many dirs open\n");
errno = EMFILE;
return -5;
}
pdir->busy = true;
newdir = &pdir->fatdir;
strlcpy(namecopy, name, sizeof(namecopy));
@ -230,11 +245,13 @@ int mkdir_uncached(const char *name)
if(!dir) {
DEBUGF("mkdir: can't open parent dir\n");
pdir->busy = false;
return -2;
}
if(basename[0] == 0) {
DEBUGF("mkdir: Empty dir name\n");
pdir->busy = false;
errno = EINVAL;
return -3;
}
@ -245,14 +262,16 @@ int mkdir_uncached(const char *name)
DEBUGF("mkdir error: file exists\n");
errno = EEXIST;
closedir_uncached(dir);
pdir->busy = false;
return - 4;
}
}
memset(&newdir, 0, sizeof(struct fat_dir));
memset(newdir, 0, sizeof(struct fat_dir));
rc = fat_create_dir(basename, &newdir, &(dir->fatdir));
rc = fat_create_dir(basename, newdir, &(dir->fatdir));
closedir_uncached(dir);
pdir->busy = false;
return rc;
}