From 6d656814ddbf826237a3e74efc10a2e6f9a46e1e Mon Sep 17 00:00:00 2001
From: Solomon Peachy <pizza@shaftnet.org>
Date: Sun, 20 Apr 2025 16:54:29 -0400
Subject: [PATCH] api: Fix some basic syntax problems with the plugin API
 generator

Change-Id: I9e6afa5b75e7fb803ee4c29f8306b56d7f8d7f64
---
 utils/rockbox_api/functions.php | 22 +++++++++++-----------
 utils/rockbox_api/gen_html.php  |  4 ++--
 utils/rockbox_api/generate.php  |  4 ++--
 utils/rockbox_api/update.php    |  4 ++--
 4 files changed, 17 insertions(+), 17 deletions(-)

diff --git a/utils/rockbox_api/functions.php b/utils/rockbox_api/functions.php
index d66caa1b29..2dc35eb4bc 100755
--- a/utils/rockbox_api/functions.php
+++ b/utils/rockbox_api/functions.php
@@ -1,4 +1,4 @@
-<?
+<?php
 $svn = "http://svn.rockbox.org/viewvc.cgi/trunk/";
 $wiki = "http://www.rockbox.org/wiki/";
 
@@ -12,10 +12,10 @@ function func_sort($a, $b)
 function get_newest()
 {
     global $svn;
-    
-    $mypath = $_SERVER['SCRIPT_FILENAME'];
-    $mypath = substr($mypath, 0, strrpos($mypath, "/"))."/";
-    
+
+    $mypath = "./"; //$_SERVER['SCRIPT_FILENAME'];
+//    $mypath = substr($mypath, 0, strrpos($mypath, "/"))."/";
+
     $text = file_get_contents($mypath."../../apps/plugin.h");
 
     $text = str_replace(array("\r\n", "\r"), "\n", $text);
@@ -55,7 +55,7 @@ function get_newest()
     for($i=0; $i<count($text); $i++)
     {
         $tmp = trim($text[$i]);
-        
+
         if(substr($tmp, 0, 1) == '#')
         {
             $tmp = trim(substr($tmp, 1));
@@ -196,7 +196,7 @@ function get_args($func)
     $buffer = "";
     for($i=0; $i<strlen($func); $i++)
     {
-        switch($func{$i})
+        switch($func[$i])
         {
             case "(":
                 $level++;
@@ -234,7 +234,7 @@ function get_args($func)
                     $buffer .= ",";
             break;
             default:
-                $buffer .= $func{$i};
+                $buffer .= $func[$i];
             break;
         }
     }
@@ -295,8 +295,8 @@ function split_var($var)
 
 function _simplify($text)
 {
-    $text = ereg_replace('\(!\( (.*)[ ]?\)\)', '!\1', $text);
-    $text = ereg_replace('\(\(([^ ])\)\)', '\1', $text);
+//    $text = ereg_replace('\(!\( (.*)[ ]?\)\)', '!\1', $text);
+//    $text = preg_replace('/\(\((.*])\)\)/', '${1}', $text);
     return $text;
 }
 
@@ -313,7 +313,7 @@ function do_see_markup($data)
     foreach($data as $el)
     {
         $el = trim($el);
-        
+
         if(substr($el, 0, 1) != "[")
            $ret[] = do_markup("[F[".$el."]]");
         else
diff --git a/utils/rockbox_api/gen_html.php b/utils/rockbox_api/gen_html.php
index d85d5f86b4..212d70c03f 100755
--- a/utils/rockbox_api/gen_html.php
+++ b/utils/rockbox_api/gen_html.php
@@ -1,5 +1,5 @@
 #!/usr/bin/php
-<?
+<?php
 require_once("functions.php");
 
 function get_group($text)
@@ -134,4 +134,4 @@ foreach($inh as $group_name => $group)
 }
 
 copy($mypath."layout.css", "output/layout.css");
-?>
\ No newline at end of file
+?>
diff --git a/utils/rockbox_api/generate.php b/utils/rockbox_api/generate.php
index 29dd69588a..3cd6dfbfe1 100755
--- a/utils/rockbox_api/generate.php
+++ b/utils/rockbox_api/generate.php
@@ -1,5 +1,5 @@
 #!/usr/bin/php
-<?
+<?php
 require_once("functions.php");
 
 echo   '# Auto generated documentation by Rockbox plugin API generator v2'."\n";
@@ -60,4 +60,4 @@ foreach(get_newest() as $line)
 }
 
 echo "\n# END\n";
-?>
\ No newline at end of file
+?>
diff --git a/utils/rockbox_api/update.php b/utils/rockbox_api/update.php
index 5fb46c9d58..6f002c33c9 100755
--- a/utils/rockbox_api/update.php
+++ b/utils/rockbox_api/update.php
@@ -1,5 +1,5 @@
 #!/usr/bin/php
-<?
+<?php
 require_once("functions.php");
 
 $input = file_get_contents($argv[1]);
@@ -158,4 +158,4 @@ foreach($merged as $func => $line)
 }
 
 echo "\n# END\n";
-?>
\ No newline at end of file
+?>