devs/foxbox
1
0
Fork 0
forked from len0rd/rockbox
Code Pull requests Activity

lcd_framebuffer bugfixes, sanity checks

Browse source 
several issues I saw that could pontentially cause problems
scroll engine doesn't take text height into account when checking bounds

NBELEMS was one whole row too large hopefully I got them right this time

Change-Id: If303da8320429c3964fc675351cb088d46303745
This commit is contained in:
William Wilgus 2020-10-31 00:18:57 -04:00
parent 202f9df0c1
commit 60f642ba4f
7 changed files with 55 additions and 24 deletions
Download patch file Download diff file Expand all files Collapse all files

8
firmware/drivers/lcd-16bit-common.c
View file

@ -81,11 +81,12 @@ void lcd_clear_viewport(void)
}
else
{
if (!lcd_backdrop)
if (lcd_backdrop && lcd_current_viewport->buffer == &lcd_framebuffer_default)
{
do
{
memset16(dst, lcd_current_viewport->bg_pattern, len);
memcpy(dst, PTR_ADD(dst, lcd_backdrop_offset),
len * sizeof(fb_data));
dst += step;
}
while (dst <= dst_end);
@ -94,8 +95,7 @@ void lcd_clear_viewport(void)
{
do
{
memcpy(dst, PTR_ADD(dst, lcd_backdrop_offset),
len * sizeof(fb_data));
memset16(dst, lcd_current_viewport->bg_pattern, len);
dst += step;
}
while (dst <= dst_end);