devs/foxbox
1
0
Fork 0
forked from len0rd/rockbox
Code Pull requests Activity

imx233/i2c: use 1sec timeout by default instead of blocking

Browse source 
These functions are mostly used by the radio drivers and any blocking
call could potentially block the entire UI, which is pretty bad.
Since any request is expected to finish within a few us, having a 10ms
timeout doesn't seem unreasonable.

Change-Id: I03b19729511547e5bbdeb3476d020e5d87d0d7e1
This commit is contained in:
Amaury Pouly 2013-10-21 01:10:59 +02:00
parent 6006eb59b1
commit 5b3eaf6f5b
1 changed files with 4 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

8
firmware/target/arm/imx233/i2c-imx233.c
View file

@ -240,7 +240,7 @@ int i2c_write(int device, const unsigned char* buf, int count)
imx233_i2c_begin();
imx233_i2c_add(true, true, &addr, 1, false); /* start + dev addr */
imx233_i2c_add(false, true, (void *)buf, count, true); /* data + stop */
return imx233_i2c_end(TIMEOUT_BLOCK);
return imx233_i2c_end(1);
}
int i2c_read(int device, unsigned char* buf, int count)
@ -249,7 +249,7 @@ int i2c_read(int device, unsigned char* buf, int count)
imx233_i2c_begin();
imx233_i2c_add(true, true, &addr, 1, false); /* start + dev addr */
imx233_i2c_add(false, false, buf, count, true); /* data + stop */
return imx233_i2c_end(TIMEOUT_BLOCK);
return imx233_i2c_end(1);
}
int i2c_readmem(int device, int address, unsigned char* buf, int count)
@ -260,7 +260,7 @@ int i2c_readmem(int device, int address, unsigned char* buf, int count)
imx233_i2c_add(true, true, start, 2, false); /* start + dev addr + addr */
imx233_i2c_add(true, true, &addr_rd, 1, false); /* start + dev addr */
imx233_i2c_add(false, false, buf, count, true); /* data + stop */
return imx233_i2c_end(TIMEOUT_BLOCK);
return imx233_i2c_end(1);
}
int i2c_writemem(int device, int address, const unsigned char* buf, int count)
@ -269,5 +269,5 @@ int i2c_writemem(int device, int address, const unsigned char* buf, int count)
imx233_i2c_begin();
imx233_i2c_add(true, true, start, 2, false); /* start + dev addr + addr */
imx233_i2c_add(false, true, (void *)buf, count, true); /* data + stop */
return imx233_i2c_end(TIMEOUT_BLOCK);
return imx233_i2c_end(1);
}