From 4cf65ec926e9128a22a539c6eda047a53f582a9b Mon Sep 17 00:00:00 2001 From: Christian Soffke Date: Fri, 13 Dec 2024 20:19:37 +0100 Subject: [PATCH] metadata: mp3: fix iTunSMPB info replacing comment Data from the iTunes seamless playback data field (support for which was introduced in f3e5ced) prevents proper comments from being displayed. Change-Id: Ifb00b1229e636a79a460ba6d706191fcf28b1502 --- lib/rbcodec/metadata/id3tags.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/lib/rbcodec/metadata/id3tags.c b/lib/rbcodec/metadata/id3tags.c index 7006f5e739..26614608e9 100644 --- a/lib/rbcodec/metadata/id3tags.c +++ b/lib/rbcodec/metadata/id3tags.c @@ -1123,7 +1123,6 @@ retry_with_limit: break; tag[bytesread] = 0; - bufferpos += bytesread + 1; /* parse the tag if it contains iTunes gapless info */ if (itunes_gapless) @@ -1131,8 +1130,11 @@ retry_with_limit: itunes_gapless = false; entry->lead_trim = get_itunes_int32(tag, 1); entry->tail_trim = get_itunes_int32(tag, 2); + break; } + bufferpos += bytesread + 1; + /* Note that parser functions sometimes set *ptag to NULL, so * the "!*ptag" check here doesn't always have the desired * effect. Should the parser functions (parsegenre in