devs/foxbox
1
0
Fork 0
forked from len0rd/rockbox
Code Pull requests Activity

build: Properly generate build dependency for autogenerated bitmap .h files

Browse source 
* bmp2rb generated a .h file that rockbox .c files used.
 * .h files in .c files were used to generate dependency graphs for make
 * When Make saw the .h file for the bitmap, it didn't know how what
   to do with them
 * Only arose in parallel builds

Fixed this by adding explicit dependencies for the .h files as part of
the existing 'bmpdepfile' function.

Solves the Xduoo X3 bootloader build failure that I could trigger 100%
of the time by using 'make -j8'

Change-Id: I6b3e78dde26c820a3b6c7c286e7d6c981b8e01fc
This commit is contained in:
Solomon Peachy 2018-12-25 10:33:35 -05:00
parent 9b3f22ac3a
commit 4c933a1d01
1 changed files with 2 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

2
tools/functions.make
View file

@ -55,8 +55,10 @@ bmpdepfile = $(SILENT) \
for each in $(2); do \
obj=`echo $$each | sed -e 's/\.bmp/.o/' -e 's:$(ROOTDIR):$(BUILDDIR):'`; \
src=`echo $$each | sed -e 's/\.bmp/.c/' -e 's:$(ROOTDIR):$(BUILDDIR):'`; \
hdr=`echo $$each | sed -e 's/.*\/\(.*\)\..*\.bmp/bitmaps\/\1\.h/'`; \
echo $$obj: $$src; \
echo $$src: $$each; \
echo $(BUILDDIR)/$$hdr: $$src; \
done \
>> $(1)