From 4a1988d31bcf8361f92ca74c460077ee6cb64ba7 Mon Sep 17 00:00:00 2001 From: Solomon Peachy Date: Tue, 14 Jul 2020 21:38:16 -0400 Subject: [PATCH] debug ata: Distinguish between Advanced power management and basic PM The old debug menu item covered APM, which is optional in the ATA spec However, despite basic power management being mandatory, several popular ATA/CF->SD adapters do not advertise PM support and have problems when it is used. An earlier patch (g#2500 / 5462907) disabled sleep when the PM capability bit was not set; this makes it visible in the debug menu. Change-Id: I2f3dd1244798d7bbb8239ac159c6470774b0c05e --- apps/debug_menu.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/apps/debug_menu.c b/apps/debug_menu.c index a46c169844..bc272e2a85 100644 --- a/apps/debug_menu.c +++ b/apps/debug_menu.c @@ -1407,9 +1407,12 @@ static int disk_callback(int btn, struct gui_synclist *lists) "Free: %ld MB", free / 1024); simplelist_addline( "Spinup time: %d ms", storage_spinup_time() * (1000/HZ)); - i = identify_info[83] & (1<<3); + i = identify_info[82] & (1<<3); simplelist_addline( "Power mgmt: %s", i ? "enabled" : "unsupported"); + i = identify_info[83] & (1<<3); + simplelist_addline( + "Adv Power mgmt: %s", i ? "enabled" : "unsupported"); i = identify_info[83] & (1<<9); simplelist_addline( "Noise mgmt: %s", i ? "enabled" : "unsupported");