devs/foxbox
1
0
Fork 0
forked from len0rd/rockbox
Code Pull requests Activity

dsp: Partial revert of previous commit, just disable warning

Browse source 
The "fix" produces different asm and I don't have the bandwidth
to determine if it's functionally equivalent.

Change-Id: I822557d1244f8e8a05e7ebfc45da2643152345a4
This commit is contained in:
Solomon Peachy 2025-04-22 10:23:14 -04:00
parent 865de6b907
commit 4096669eb5
1 changed files with 10 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

12
lib/rbcodec/dsp/compressor.c
View file

@ -266,6 +266,10 @@ static bool compressor_update(struct dsp_config *dsp,
* [3] = 0 db input * [3] = 0 db input
* [4] = ~+12db input (2 bits clipping overhead) * [4] = ~+12db input (2 bits clipping overhead)
*/ */
#if (__GNUC__ >= 6)
#pragma GCC diagnostic push
#pragma GCC diagnostic ignored "-Wshift-negative-value"
#endif
db_curve[1].db = threshold << 16; db_curve[1].db = threshold << 16;
if (soft_knee) if (soft_knee)
@ -276,11 +280,11 @@ static bool compressor_update(struct dsp_config *dsp,
db_curve[2].db = db_curve[1].db + (3 << 16); db_curve[2].db = db_curve[1].db + (3 << 16);
if (ratio) if (ratio)
/* offset = -3db * (ratio - 1) / ratio */ /* offset = -3db * (ratio - 1) / ratio */
db_curve[2].offset = (int32_t)((long long)(-3UL << 16) db_curve[2].offset = (int32_t)((long long)(-3 << 16)
* (ratio - 1) / ratio); * (ratio - 1) / ratio);
else else
/* offset = -3db for hard limit */ /* offset = -3db for hard limit */
db_curve[2].offset = (-3UL << 16); db_curve[2].offset = (-3 << 16);
} }
else else
{ {
@ -291,6 +295,10 @@ static bool compressor_update(struct dsp_config *dsp,
db_curve[2].offset = 0; db_curve[2].offset = 0;
} }
#if (__GNUC__ >= 6)
#pragma GCC diagnostic pop
#endif
/* Calculate 0db and ~+12db offsets */ /* Calculate 0db and ~+12db offsets */
db_curve[4].db = 0xC0A8C; /* db of 2 bits clipping */ db_curve[4].db = 0xC0A8C; /* db of 2 bits clipping */
if (ratio) if (ratio)