devs/foxbox
1
0
Fork 0
forked from len0rd/rockbox
Code Pull requests Activity

Completely rework RbSettings class.

Browse source 
- use a single member function for accessing a settings value.
- use an enum to figure the correct value in the settings file instead of functions.
- return the settings value as QVariant instead and leave converting to the caller.
- accept QVariant as value when setting values.


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@20823 a1c6a512-1295-4272-9138-f99709370657
This commit is contained in:
Dominik Riebeling 2009-04-29 20:58:47 +00:00
parent 3c5e67516b
commit 3d2e42ab4c
16 changed files with 557 additions and 840 deletions
Download patch file Download diff file Expand all files Collapse all files

7
rbutil/rbutilqt/base/detect.cpp
View file

@ -401,12 +401,13 @@ QString Detect::check(RbSettings* settings, bool permission)
}
// Check TargetId
QString installed = installedTarget(settings->mountpoint());
if(!installed.isEmpty() && installed != settings->curConfigure_Modelname())
QString installed = installedTarget(settings->value(RbSettings::Mountpoint).toString());
if(!installed.isEmpty() && installed != settings->value(RbSettings::CurConfigureModel).toString())
{
text += QObject::tr("<li>Target mismatch detected.\n"
"Installed target: %1, selected target: %2.</li>")
.arg(installed, settings->curName());
.arg(installed, settings->value(RbSettings::CurPlatformName).toString());
// FIXME: replace installed by human-friendly name
}
if(!text.isEmpty())