devs/foxbox
1
0
Fork 0
forked from len0rd/rockbox
Code Pull requests Activity

voice: Convert a pile of splashf() messages to be voiced

Browse source 
Basically, this just replaces str(STRID) with ID2P(STRID).

The voiced version of these strings cannot not have any format
specifiers (enforced by the language tooling) and are instead more
generic.

As many of these are error conditions, it is doubly important for
them to be voiced in some way.

There are some places in the code that perform their own voicing
for splash messages (eg the shutdown code); those are left alone.

Change-Id: I7d51af351e8fa5c4beee42fbfc02719f1d6591b8
This commit is contained in:
Solomon Peachy 2025-05-17 17:33:46 -04:00
parent cde144233b
commit 39f86858c4
15 changed files with 29 additions and 29 deletions
Download patch file Download diff file Expand all files Collapse all files

4
apps/gui/skin_engine/skin_parser.c
View file

@ -2173,7 +2173,7 @@ static bool skin_load_fonts(struct wps_data *data)
{
if (success)
{
splashf(HZ, str(LANG_FONT_LOAD_ERROR), "(no name)");
splashf(HZ, ID2P(LANG_FONT_LOAD_ERROR), "(no name)");
DEBUGF("font %d not specified\n", font_id);
}
success = false;
@ -2198,7 +2198,7 @@ static bool skin_load_fonts(struct wps_data *data)
if (font->id < 0)
{
splashf(HZ, str(LANG_FONT_LOAD_ERROR), font->name);
splashf(HZ, ID2P(LANG_FONT_LOAD_ERROR), font->name);
DEBUGF("Unable to load font %d: '%s'\n", font_id, font->name);
font->name = NULL; /* to stop trying to load it again if we fail */
success = false;