devs/foxbox
1
0
Fork 0
forked from len0rd/rockbox
Code Pull requests Activity

playback.c use file_exists rather than open to check for bad files

Browse source 
the worst case is really slow for open

Change-Id: Ifcfe366ad9bee7ff43a0572e52f15b5c6f608288
This commit is contained in:
William Wilgus 2022-03-11 03:16:51 -05:00 • committed by William Wilgus
parent 603412f447
commit 359c66982f
1 changed files with 7 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

12
apps/playback.c
View file

@ -1907,11 +1907,13 @@ static int audio_load_track(void)
break; break;
/* Test for broken playlists by probing for the files */ /* Test for broken playlists by probing for the files */
fd = open(path, O_RDONLY); if (file_exists(path))
if (fd >= 0) {
break; fd = open(path, O_RDONLY);
if (fd >= 0)
logf("Open failed"); break;
}
logf("Open failed %s", path);
/* only skip if failed track has a successor in playlist */ /* only skip if failed track has a successor in playlist */
if (!playlist_peek(playlist_peek_offset + 1, NULL, 0)) if (!playlist_peek(playlist_peek_offset + 1, NULL, 0))