devs/foxbox
1
0
Fork 0
forked from len0rd/rockbox
Code Pull requests Activity

Make the formatter functions used by the settings return a pointer to avoid usless copying of lang strings, this brought with it a long chain of const correctness and a few random cleanups

Browse source 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@22440 a1c6a512-1295-4272-9138-f99709370657
This commit is contained in:
Nils Wallménius 2009-08-20 16:47:44 +00:00
parent 0a17284448
commit 3200d04d75
43 changed files with 191 additions and 170 deletions
Download patch file Download diff file Expand all files Collapse all files

13
apps/plugins/mpegplayer/mpeg_settings.c
View file

@ -317,7 +317,7 @@ static bool mpeg_set_int(const char *string, const char *unit,
void (*function)(int), int step,
int min,
int max,
void (*formatter)(char*, size_t, int, const char*))
const char* (*formatter)(char*, size_t, int, const char*))
{
mpeg_menu_sysevent_clear();
@ -350,15 +350,16 @@ static void backlight_brightness_function(int value)
mpeg_backlight_update_brightness(value);
}
static void backlight_brightness_formatter(char *buf, size_t length,
int value, const char *input)
static const char* backlight_brightness_formatter(char *buf, size_t length,
int value, const char *input)
{
(void)input;
if (value < 0)
rb->strlcpy(buf, BACKLIGHT_OPTION_DEFAULT, length);
return BACKLIGHT_OPTION_DEFAULT;
else
rb->snprintf(buf, length, "%d", value + MIN_BRIGHTNESS_SETTING);
(void)input;
return buf;
}
#endif /* HAVE_BACKLIGHT_BRIGHTNESS */