devs/foxbox
1
0
Fork 0
forked from len0rd/rockbox
Code Pull requests Activity

plugins: properties: keep theme enabled

Browse source 
Launching a themed plugin can cause the screen to
flash due to the theme being disabled, before it
is re-enabled right away. For the Properties plugin
in particular, this seems a bit annoying and
unnecessary.

Change-Id: Ifa0275b453369051cc63a3c626551f54120fdb41
This commit is contained in:
Christian Soffke 2024-07-26 23:25:23 +02:00
parent cb7ae38fcd
commit 2f8cab9190
2 changed files with 15 additions and 11 deletions
Download patch file Download diff file Expand all files Collapse all files

5
apps/plugins/properties.c
View file

@ -321,8 +321,6 @@ enum plugin_status plugin_start(const void* parameter)
rb->action_userabort(TIMEOUT_BLOCK);
return PLUGIN_OK;
}
FOR_NB_SCREENS(i)
rb->viewportmanager_theme_enable(i, true, NULL);
if (props_type == PROPS_MUL_ID3)
ret = assemble_track_info(NULL, NULL);
@ -349,8 +347,5 @@ enum plugin_status plugin_start(const void* parameter)
rb->browse_id3(&id3, 0, 0, NULL, mul_id3_count) :
(stats.canceled ? 0 : -1);
FOR_NB_SCREENS(i)
rb->viewportmanager_theme_undo(i, false);
return ret == -1 ? PLUGIN_ERROR : ret == 1 ? PLUGIN_USB_CONNECTED : PLUGIN_OK;
}