devs/foxbox
1
0
Fork 0
forked from len0rd/rockbox
Code Pull requests Activity

imx233: clarity comment about errata

Browse source 
Change-Id: I3309ce112762f09fcf6bce9d416dbf4b0aa2f197
This commit is contained in:
Amaury Pouly 2013-06-17 00:25:05 +02:00
parent 63ffdc1c89
commit 2ed36fc4a2
1 changed files with 3 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

4
firmware/target/arm/imx233/i2c-imx233.c
View file

@ -88,14 +88,16 @@ void imx233_i2c_init(void)
imx233_pinctrl_setup_vpin(VPIN_I2C_SDA, "i2c sda", PINCTRL_DRIVE_4mA, true); imx233_pinctrl_setup_vpin(VPIN_I2C_SDA, "i2c sda", PINCTRL_DRIVE_4mA, true);
/* clear softreset */ /* clear softreset */
imx233_reset_block(&HW_I2C_CTRL0); imx233_reset_block(&HW_I2C_CTRL0);
/* Errata: /* Errata (imx233):
* When RETAIN_CLOCK is set, the ninth clock pulse (ACK) is not generated. However, the SDA * When RETAIN_CLOCK is set, the ninth clock pulse (ACK) is not generated. However, the SDA
* line is read at the proper timing interval. If RETAIN_CLOCK is cleared, the ninth clock pulse is * line is read at the proper timing interval. If RETAIN_CLOCK is cleared, the ninth clock pulse is
* generated. * generated.
* HW_I2C_CTRL1[ACK_MODE] has default value of 0. It should be set to 1 to enable the fix for * HW_I2C_CTRL1[ACK_MODE] has default value of 0. It should be set to 1 to enable the fix for
* this issue. * this issue.
*/ */
#if IMX233_SUBTARGET >= 3780
BF_SET(I2C_CTRL1, ACK_MODE); BF_SET(I2C_CTRL1, ACK_MODE);
#endif
BF_SET(I2C_CTRL0, CLKGATE); BF_SET(I2C_CTRL0, CLKGATE);
/* Fast-mode @ 400K */ /* Fast-mode @ 400K */
HW_I2C_TIMING0 = 0x000F0007; /* tHIGH=0.6us, read at 0.3us */ HW_I2C_TIMING0 = 0x000F0007; /* tHIGH=0.6us, read at 0.3us */