devs/foxbox
1
0
Fork 0
forked from len0rd/rockbox
Code Pull requests Activity

[COV] metadata module, fix uninit warnings

Browse source 
Change-Id: Ifeb22642d7fb683542ff9dcfca0bc58c91ab5f38
This commit is contained in:
William Wilgus 2022-03-20 09:06:40 -04:00
parent ccdd9e6784
commit 2a88ec50cd
4 changed files with 9 additions and 9 deletions
Download patch file Download diff file Expand all files Collapse all files

2
lib/rbcodec/metadata/aac.c
View file

@ -41,7 +41,7 @@ static const int sample_rates[] =
static bool check_adts_syncword(int fd) static bool check_adts_syncword(int fd)
{ {
uint16_t syncword; uint16_t syncword = 0;
read_uint16be(fd, &syncword); read_uint16be(fd, &syncword);
return (syncword & 0xFFF6) == 0xFFF0; return (syncword & 0xFFF6) == 0xFFF0;

6
lib/rbcodec/metadata/asf.c
View file

@ -129,9 +129,9 @@ static int asf_intdecode(int fd, int type, int length)
{ {
int bytes = 0; int bytes = 0;
int ret; int ret;
uint16_t tmp16; uint16_t tmp16 = 0;
uint32_t tmp32; uint32_t tmp32 = 0;
uint64_t tmp64; uint64_t tmp64 = 0;
if (type == 3) { if (type == 3) {
bytes = read_uint32le(fd, &tmp32); bytes = read_uint32le(fd, &tmp32);

2
lib/rbcodec/metadata/metadata_common.c
View file

@ -98,7 +98,7 @@ int read_uint32be(int fd, uint32_t* buf)
int read_uint64be(int fd, uint64_t* buf) int read_uint64be(int fd, uint64_t* buf)
{ {
size_t n; size_t n;
uint8_t data[8]; uint8_t data[8] = {0};
int i; int i;
n = read(fd, data, 8); n = read(fd, data, 8);

8
lib/rbcodec/metadata/mp4.c
View file

@ -195,7 +195,7 @@ static unsigned int read_mp4_length(int fd, uint32_t* size)
{ {
unsigned int length = 0; unsigned int length = 0;
int bytes = 0; int bytes = 0;
unsigned char c; unsigned char c = '\0';
do do
{ {
@ -211,7 +211,7 @@ static unsigned int read_mp4_length(int fd, uint32_t* size)
static bool read_mp4_esds(int fd, struct mp3entry* id3, uint32_t* size) static bool read_mp4_esds(int fd, struct mp3entry* id3, uint32_t* size)
{ {
unsigned char buf[8]; unsigned char buf[8] = {0};
bool sbr = false; bool sbr = false;
lseek(fd, 4, SEEK_CUR); /* Version and flags. */ lseek(fd, 4, SEEK_CUR); /* Version and flags. */
@ -789,8 +789,8 @@ static bool read_mp4_container(int fd, struct mp3entry* id3,
{ {
/* ADDME: add support for real chapters. Right now it's only /* ADDME: add support for real chapters. Right now it's only
* used for Nero's gapless hack */ * used for Nero's gapless hack */
uint8_t chapters; uint8_t chapters = 0;
uint64_t timestamp; uint64_t timestamp = 0;
lseek(fd, 8, SEEK_CUR); lseek(fd, 8, SEEK_CUR);
read_uint8(fd, &chapters); read_uint8(fd, &chapters);