devs/foxbox
1
0
Fork 0
forked from len0rd/rockbox
Code Pull requests Activity

Just take out some out-of-date TODOs from playback.c and put a big FIXME in pcmbuf.c

Browse source 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@11217 a1c6a512-1295-4272-9138-f99709370657
This commit is contained in:
Brandon Low 2006-10-13 20:48:23 +00:00
parent 3beaad8d06
commit 1f3360f021
2 changed files with 10 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

9
apps/pcmbuf.c
View file

@ -38,7 +38,7 @@
#include "thread.h" #include "thread.h"
/* Keep watermark high for iPods at least (2s) */ /* Keep watermark high for iPods at least (2s) */
#define PCMBUF_WATERMARK (NATIVE_FREQUENCY * 8) #define PCMBUF_WATERMARK (NATIVE_FREQUENCY * 4 * 2)
/* Structure we can use to queue pcm chunks in memory to be played /* Structure we can use to queue pcm chunks in memory to be played
* by the driver code. */ * by the driver code. */
@ -203,6 +203,13 @@ process_new_buffer:
*realsize = 0; *realsize = 0;
*realstart = NULL; *realstart = NULL;
CALL_IF_EXISTS(pcmbuf_event_handler); CALL_IF_EXISTS(pcmbuf_event_handler);
/* FIXME: We need to find another way to keep the CPU from
* being left boosted, because this is boosting in interrupt
* context. This is also not a good thing, because it will
* result in the CPU being deboosted if there is a legitimate
* buffer underrun (albeit only temporarily, because someone
* will reboost it soon, but it will make the skip longer
* than necessary. */
pcmbuf_boost(false); pcmbuf_boost(false);
} }
} }

9
apps/playback.c
View file

@ -17,19 +17,14 @@
* *
****************************************************************************/ ****************************************************************************/
/* TODO: Check for a possibly broken codepath on a rapid skip, stop event */
/* TODO: same in reverse ^^ */
/* TODO: Also play, stop ^^ */
/* TODO: Can use the track changed callback to detect end of track and seek /* TODO: Can use the track changed callback to detect end of track and seek
* in the previous track until this happens */ * in the previous track until this happens */
/* TODO: Pause should be handled in here, rather than PCMBUF so that voice can
* play whilst audio is paused */
/* Design: we have prev_ti already, have a conditional for what type of seek /* Design: we have prev_ti already, have a conditional for what type of seek
* to do on a seek request, if it is a previous track seek, skip previous, * to do on a seek request, if it is a previous track seek, skip previous,
* and in the request_next_track callback set the offset up the same way that * and in the request_next_track callback set the offset up the same way that
* starting from an offset works. */ * starting from an offset works. */
/* This is also necesary to prevent the problem with buffer overwriting on /* TODO: Pause should be handled in here, rather than PCMBUF so that voice can
* automatic track changes */ * play whilst audio is paused */
#include <stdio.h> #include <stdio.h>
#include <string.h> #include <string.h>