devs/foxbox
1
0
Fork 0
forked from len0rd/rockbox
Code Pull requests Activity

text editor: decrease size of extension to reduce stack usage.

Browse source 
this could solve crash in text editor (FS#10078).

git-svn-id: svn://svn.rockbox.org/rockbox/trunk@28189 a1c6a512-1295-4272-9138-f99709370657
This commit is contained in:
Teruaki Kawashima 2010-10-01 14:40:28 +00:00
parent 55a63609ef
commit 15e8460053
1 changed files with 29 additions and 30 deletions
Download patch file Download diff file Expand all files Collapse all files

13
apps/plugins/text_editor.c
View file

@ -410,15 +410,15 @@ enum plugin_status plugin_start(const void* parameter)
if (edit_colors_file && line_count) if (edit_colors_file && line_count)
{ {
char *name = temp_line, *value = NULL; char *name = temp_line, *value = NULL;
char extension[MAX_LINE_LEN]; char extension[16];
int color, old_color; int color, old_color;
bool temp_changed = false; bool temp_changed = false;
rb->settings_parseline(temp_line, &name, &value);
if (line_count)
{
MENUITEM_STRINGLIST(menu, "Edit What?", NULL, MENUITEM_STRINGLIST(menu, "Edit What?", NULL,
"Extension", "Colour"); "Extension", "Colour");
rb->strcpy(extension, name);
rb->settings_parseline(temp_line, &name, &value);
rb->strlcpy(extension, name, sizeof(extension));
if (value) if (value)
my_hex_to_rgb(value, &color); my_hex_to_rgb(value, &color);
else else
@ -427,7 +427,7 @@ enum plugin_status plugin_start(const void* parameter)
switch (rb->do_menu(&menu, NULL, NULL, false)) switch (rb->do_menu(&menu, NULL, NULL, false))
{ {
case 0: case 0:
temp_changed = !rb->kbd_input(extension,MAX_LINE_LEN); temp_changed = !rb->kbd_input(extension, sizeof(extension));
break; break;
case 1: case 1:
old_color = color; old_color = color;
@ -446,7 +446,6 @@ enum plugin_status plugin_start(const void* parameter)
changed = true; changed = true;
} }
} }
}
else else
#endif #endif
if (!rb->kbd_input(temp_line,MAX_LINE_LEN)) if (!rb->kbd_input(temp_line,MAX_LINE_LEN))