devs/foxbox
1
0
Fork 0
forked from len0rd/rockbox
Code Pull requests Activity

rbutil: Fix various issues found by clazy.

Browse source 
Change-Id: I91ca2baed34f0f3b561602f95f66bbd4e17e74ab
This commit is contained in:
Dominik Riebeling 2021-12-25 19:59:57 +01:00
parent 0768705545
commit 01e245417e
9 changed files with 15 additions and 19 deletions
Download patch file Download diff file Expand all files Collapse all files

5
utils/rbutilqt/gui/selectiveinstallwidget.cpp
View file

@ -277,7 +277,6 @@ void SelectiveInstallWidget::installBootloader(void)
if(ui.bootloaderCheckbox->isChecked()) {
LOG_INFO() << "installing bootloader";
QString platform = RbSettings::value(RbSettings::Platform).toString();
QString backupDestination = "";
// create installer
@ -509,7 +508,6 @@ void SelectiveInstallWidget::installVoicefile(void)
RockboxInfo installInfo(m_mountpoint);
QString voiceurl;
QString logversion;
QString relversion = installInfo.release();
if(m_buildtype != PlayerBuildInfo::TypeRelease) {
// release is empty for non-release versions (i.e. daily / current)
logversion = installInfo.release();
@ -549,7 +547,6 @@ void SelectiveInstallWidget::installManual(void)
RockboxInfo installInfo(m_mountpoint);
QString manualurl;
QString logversion;
QString relversion = installInfo.release();
if(m_buildtype != PlayerBuildInfo::TypeRelease) {
// release is empty for non-release versions (i.e. daily / current)
logversion = installInfo.release();
@ -638,7 +635,7 @@ void SelectiveInstallWidget::installPluginData(void)
for(size_t i = 0; i < sizeof(PluginDataFiles) / sizeof(PluginDataFiles[0]); i++)
{
// check if installed Rockbox has this plugin.
if(QFileInfo(m_mountpoint + "/.rockbox/rocks/" + PluginDataFiles[i].rockfile).exists()) {
if(QFileInfo::exists(m_mountpoint + "/.rockbox/rocks/" + PluginDataFiles[i].rockfile)) {
dataName.append(PluginDataFiles[i].name);
// game URLs do not depend on the actual build type, but we need
// to pass it (simplifies the API, and will allow to make them