devs/foxbox
1
0
Fork 0
forked from len0rd/rockbox
Code Pull requests Activity

FS#9281 Rename of splash functions.

Browse source 
* Remove gui_splash()
* Rename gui_syncsplash() to splashf() and remove its voice 
capabilities.
* Rename the internal splash() to splash_internal() and introduce an 
externally visible splash() that handles simple splashing  without 
printf functionality e.g. splash(HZ, ID2P(LANG_FOO)); or splash(HZ, 
"foo"); if a LANG_* id is passed it will be voiced.
* Adjust all places that called gui_syncsplash() to use the correct 
variant from above.
* Export both new functions to plugins and adjust places calling 
rb->splash() to use the correct variant so that we now have naming 
consistency between the core and plugins.
* Fix one latent bug that would cause my sim to crash with the above 
changes and correct P2STR and P2ID macros, thanks to pondlife.


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@18282 a1c6a512-1295-4272-9138-f99709370657
This commit is contained in:
Nils Wallménius 2008-08-15 08:27:39 +00:00
parent 9464fdde2d
commit 01729e7a18
65 changed files with 276 additions and 305 deletions
Download patch file Download diff file Expand all files Collapse all files

4
apps/plugins/text_editor.c
View file

@ -350,7 +350,7 @@ enum plugin_status plugin_start(const struct plugin_api* api, const void* parame
fd = rb->open(filename,O_RDONLY);
if (fd<0)
{
rb->splash(HZ*2,"Couldnt open file: %s",(char*)parameter);
rb->splashf(HZ*2,"Couldnt open file: %s",(char*)parameter);
return PLUGIN_ERROR;
}
#ifdef HAVE_LCD_COLOR
@ -363,7 +363,7 @@ enum plugin_status plugin_start(const struct plugin_api* api, const void* parame
{
if (!do_action(ACTION_INSERT,temp_line,line_count))
{
rb->splash(HZ*2,"Error reading file: %s",(char*)parameter);
rb->splashf(HZ*2,"Error reading file: %s",(char*)parameter);
rb->close(fd);
return PLUGIN_ERROR;
}