devs/foxbox
1
0
Fork 0
forked from len0rd/rockbox
Code Pull requests Activity

FS#9281 Rename of splash functions.

Browse source 
* Remove gui_splash()
* Rename gui_syncsplash() to splashf() and remove its voice 
capabilities.
* Rename the internal splash() to splash_internal() and introduce an 
externally visible splash() that handles simple splashing  without 
printf functionality e.g. splash(HZ, ID2P(LANG_FOO)); or splash(HZ, 
"foo"); if a LANG_* id is passed it will be voiced.
* Adjust all places that called gui_syncsplash() to use the correct 
variant from above.
* Export both new functions to plugins and adjust places calling 
rb->splash() to use the correct variant so that we now have naming 
consistency between the core and plugins.
* Fix one latent bug that would cause my sim to crash with the above 
changes and correct P2STR and P2ID macros, thanks to pondlife.


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@18282 a1c6a512-1295-4272-9138-f99709370657
This commit is contained in:
Nils Wallménius 2008-08-15 08:27:39 +00:00
parent 9464fdde2d
commit 01729e7a18
65 changed files with 276 additions and 305 deletions
Download patch file Download diff file Expand all files Collapse all files

6
apps/plugins/sokoban.c
View file

@ -618,7 +618,7 @@ static bool read_levels(bool initialize)
buffered_boards.start = 0;
if ((fd = rb->open(buffered_boards.filename, O_RDONLY)) < 0) {
rb->splash(HZ*2, "Unable to open %s", buffered_boards.filename);
rb->splashf(HZ*2, "Unable to open %s", buffered_boards.filename);
return false;
}
@ -930,7 +930,7 @@ static bool save(char *filename, bool solution)
if (filename[0] == '\0' ||
(fd = rb->open(filename, O_WRONLY|O_CREAT|O_TRUNC)) < 0) {
rb->splash(HZ*2, "Unable to open %s", filename);
rb->splashf(HZ*2, "Unable to open %s", filename);
return false;
}
@ -965,7 +965,7 @@ static bool load(char *filename, bool silent)
if (filename[0] == '\0' || (fd = rb->open(filename, O_RDONLY)) < 0) {
if (!silent)
rb->splash(HZ*2, "Unable to open %s", filename);
rb->splashf(HZ*2, "Unable to open %s", filename);
return false;
}