devs/foxbox
1
0
Fork 0
forked from len0rd/rockbox
Code Pull requests Activity

fixed a // comment, added a comment how this source file checks for features

Browse source 
the wrong way. I didn't address the actual error due to limited time.


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@4128 a1c6a512-1295-4272-9138-f99709370657
This commit is contained in:
Daniel Stenberg 2003-12-12 10:45:50 +00:00
parent 10d6165034
commit 0167b55083
1 changed files with 6 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

8
apps/plugins/firmware_flash.c
View file

@ -44,6 +44,10 @@
#define ID_PLAYER 2 #define ID_PLAYER 2
#define ID_REC_V2 3 #define ID_REC_V2 3
/* We should never check for ARCHOS_* defines in source code. We must
check for features/hardware that have been defined in config-*.h files.
This makes it easier for us to maintain portability. */
#if defined(ARCHOS_PLAYER) #if defined(ARCHOS_PLAYER)
#define FILE_TYPE "player" #define FILE_TYPE "player"
#define KEEP VERSION_ADR /* keep the firmware version */ #define KEEP VERSION_ADR /* keep the firmware version */
@ -61,7 +65,7 @@
#define KEEP MASK_ADR /* keep the mask value */ #define KEEP MASK_ADR /* keep the mask value */
#define PLATFORM_ID ID_FM #define PLATFORM_ID ID_FM
#else #else
#error ("No known platform given!") #error "No known platform given!"
#endif #endif
/* result of the CheckFirmwareFile() function */ /* result of the CheckFirmwareFile() function */
@ -340,7 +344,7 @@ tCheckResult CheckFirmwareFile(char* filename, int chipsize, bool is_romless)
return eReadErr; return eReadErr;
} }
// version number in file plausible with this hardware? /* version number in file plausible with this hardware? */
if (!CheckPlatform(PLATFORM_ID, *(UINT16*)(sector + VERSION_ADR))) if (!CheckPlatform(PLATFORM_ID, *(UINT16*)(sector + VERSION_ADR)))
{ {
rb->close(fd); rb->close(fd);