devs/foxbox
1
0
Fork 0
forked from len0rd/rockbox
Code Pull requests Activity

When building the database and a track doesn't have an album artist tag, copy the value from the artist tag. This should make browsing through album artist in the database a bit nicer. Same as FS# 7342 but different. You may need to rebuild your database to actually see any change.

Browse source 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13710 a1c6a512-1295-4272-9138-f99709370657
This commit is contained in:
Dan Everton 2007-06-25 11:33:21 +00:00
parent 708ac7feb3
commit 00dd14922b
1 changed files with 20 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

18
apps/tagcache.c
View file

@ -1595,6 +1595,7 @@ static void add_tagcache(char *path)
char tracknumfix[3]; char tracknumfix[3];
int offset = 0; int offset = 0;
int path_length = strlen(path); int path_length = strlen(path);
bool has_albumartist;
if (cachefd < 0) if (cachefd < 0)
return ; return ;
@ -1685,6 +1686,9 @@ static void add_tagcache(char *path)
entry.tag_offset[tag_bitrate] = track.id3.bitrate; entry.tag_offset[tag_bitrate] = track.id3.bitrate;
/* String tags. */ /* String tags. */
has_albumartist = track.id3.albumartist != NULL
&& strlen(track.id3.albumartist) > 0;
ADD_TAG(entry, tag_filename, &path); ADD_TAG(entry, tag_filename, &path);
ADD_TAG(entry, tag_title, &track.id3.title); ADD_TAG(entry, tag_title, &track.id3.title);
ADD_TAG(entry, tag_artist, &track.id3.artist); ADD_TAG(entry, tag_artist, &track.id3.artist);
@ -1692,7 +1696,14 @@ static void add_tagcache(char *path)
ADD_TAG(entry, tag_genre, &track.id3.genre_string); ADD_TAG(entry, tag_genre, &track.id3.genre_string);
ADD_TAG(entry, tag_composer, &track.id3.composer); ADD_TAG(entry, tag_composer, &track.id3.composer);
ADD_TAG(entry, tag_comment, &track.id3.comment); ADD_TAG(entry, tag_comment, &track.id3.comment);
if (has_albumartist)
{
ADD_TAG(entry, tag_albumartist, &track.id3.albumartist); ADD_TAG(entry, tag_albumartist, &track.id3.albumartist);
}
else
{
ADD_TAG(entry, tag_albumartist, &track.id3.artist);
}
entry.data_length = offset; entry.data_length = offset;
/* Write the header */ /* Write the header */
@ -1706,7 +1717,14 @@ static void add_tagcache(char *path)
write_item(track.id3.genre_string); write_item(track.id3.genre_string);
write_item(track.id3.composer); write_item(track.id3.composer);
write_item(track.id3.comment); write_item(track.id3.comment);
if (has_albumartist)
{
write_item(track.id3.albumartist); write_item(track.id3.albumartist);
}
else
{
write_item(track.id3.artist);
}
total_entry_count++; total_entry_count++;
} }